Bugs/typos found by AI#161
Open
KristofferC wants to merge 10 commits into
Open
Conversation
The JuliaInterpreter 0.10 update (bcb6f63) restructured `selective_eval!` into `SelectiveInterpreter` but left a reference to the old local variable `pcexec` in `JuliaInterpreter.get_return`. Any call that stopped at a non-`return` statement whose ssavalue was assigned (e.g. reusing a frame, as the documentation demonstrates, with a controller that has termination points) threw `UndefVarError: pcexec` instead of returning the stored value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The `continue` after processing a typedef block sat inside the inner `for` loop over typedef blocks, so it never restarted the outer `while` loop as intended. Two consequences: - After advancing `idx` past the matched block, the inner loop kept matching the *new* `idx` against the remaining blocks. When two type definitions are adjacent in the lowered code (e.g. two consecutive `abstract type`s on Julia ≤1.11), requiring any statement of the first block marked the entire second block as required, causing unrelated type definitions to be (re)evaluated. - Falling out of the inner loop, the trailing `idx += 1` skipped the statement immediately after the block from ever being examined. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were found by Claude/ChatGPT and I do not think it is all AI slop. But I am a bit too much out of the loop of this package to feel confident merging it myself. I did add Revise as a downstream test, though.
pcexecinget_returnadd_typedefs!