Add polar-axis option to Makie nyquistplot#1065
Open
baggepinnen wants to merge 2 commits into
Open
Conversation
Adds a `polar` keyword to `CSMakie.nyquistplot` that draws the Nyquist curve in a `Makie.PolarAxis`, providing native polar grid lines (circles of constant magnitude and rays of constant phase) that adapt to the axis limits. A `rlimits` keyword allows limiting the radial axis, useful for systems with poles on or near the imaginary axis. Requested in discussion #1064 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KU255FUfQGyZa2cziDYf7C
Phase lag of a typical system now reads as a negative angle in the lower half-plane, following the convention of polar Nyquist charts in textbooks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KU255FUfQGyZa2cziDYf7C
|
This is an automated message.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
+ Coverage 91.64% 91.68% +0.04%
==========================================
Files 42 42
Lines 5660 5665 +5
==========================================
+ Hits 5187 5194 +7
+ Misses 473 471 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Adds a
polarkeyword option toCSMakie.nyquistplotthat draws the Nyquist curve in aMakie.PolarAxisinstead of a CartesianAxis. This provides native polar "graph paper": circles of constant magnitude and rays of constant phase, drawn and re-ticked automatically by Makie when the axis limits change, with correct aspect ratio by construction. Requested in discussion JuliaControl/ControlSystems.jl#1064.A
rlimitskeyword (forwarded toPolarAxis) allows limiting the radial axis, which is useful for systems with poles on or near the imaginary axis where the Nyquist curve reaches very large magnitudes.All existing options (
Ms_circles,Mt_circles,unit_circle,critical_point, MIMO grid layout, adaptive downsampling) work in polar mode as well; Cartesian coordinates are converted point-wise to(angle, radius).Example
🤖 Generated with Claude Code
https://claude.ai/code/session_01KU255FUfQGyZa2cziDYf7C