Preserve EXEC bind arguments and support OUTPUT parameters - #2580
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Conversation
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXEC PCK_ACTION_BY :USER_IDabsorbs the bind argument into the procedure name, andEXECUTE myProc 'foo', @outputVar OUTPUTcannot be parsed. Keep the procedure-name boundary separate from colon-prefixed arguments and represent OUTPUT/OUT modifiers with an ExecuteArgument expression.Unmarked arguments retain their existing expression types and Execute's argument-list API. The new visitor method forwards to the wrapped expression by default; the deparser and table-name visitor also dispatch it explicitly. Execute and ExecuteDeParser now share argument rendering, including parentheses, and setting a multipart procedure name replaces the previous name while preserving omitted qualifiers such as
db..p.Validation: full Gradle
checkand Mavenverify; single/multiple/qualified binds, positional and named OUTPUT arguments, OUT normalization, invalid output values, ordinary CALL/EXEC arguments, following statements, custom deparsers, visitor context and existing visitor-completeness checks.Syntax reference: Microsoft EXECUTE documentation.
Fixes #2192.
Fixes #268.