Validate data-modifying CTEs through statement validators - #2578
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Merged
Conversation
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validating
WITH x AS (DELETE FROM foo RETURNING id) SELECT * FROM xthrows ClassCastException because the CTE validator assumes every body is a SELECT. INSERT and UPDATE bodies fail the same way.Route the body through
WithItem.accept(StatementVisitor, context)and the existing statement validators. This removes the SELECT-only cast and reuses the validation and error collection already implemented for each statement type. CTE feature checks and column-list traversal remain in the select validator.Validation: full Gradle
checkand Mavenverify; INSERT/UPDATE/DELETE CTEs under restricted and permissive capabilities, ordinary/recursive/nested SELECT CTEs, multiple bodies, following statements and RETURNING expression validation. Restricted DML produces validation errors instead of runtime exceptions.Fixes #2574.