Skip to content

COMP: Restore SimpleITKFilters pin removed on release-5.4 - #6814

Merged
blowekamp merged 1 commit into
InsightSoftwareConsortium:release-5.4from
blowekamp:restore-simpleitkfilters-pin-release54
Aug 29, 2026
Merged

COMP: Restore SimpleITKFilters pin removed on release-5.4#6814
blowekamp merged 1 commit into
InsightSoftwareConsortium:release-5.4from
blowekamp:restore-simpleitkfilters-pin-release54

Conversation

@blowekamp

Copy link
Copy Markdown
Member

Summary

34853cf1ca ("COMP: Update remote-module pins toward buildable convergence with main") advanced the ITKSimpleITKFilters remote-module pin on release-5.4 to 372ab10343d. That commit removes MaskedAssignImageFilter from the remote module now that it has graduated to ITKImageIntensity core (ITKSimpleITKFilters#35, companion to #6542).

#6542 ("Add MaskedAssignImageFilter to ITKImageIntensity") was merged only to main and has not been backported to release-5.4. As a result, on current release-5.4, itkMaskedAssignImageFilter.h doesn't exist anywhere: removed from the remote module, not yet added to core.

This reverts just that one pin to the last ITKSimpleITKFilters commit that still contains the filter, restoring buildability of release-5.4 until #6542 is backported. The other 55 pin updates from 34853cf1ca are left untouched.

Found while investigating a CI failure in SimpleITK/SimpleITK#2674, which pins ITK_GIT_TAG to release-5.4 in one CI matrix job specifically to catch this kind of drift, and fails to compile sitkMaskedAssignImageFilter.cxx with a missing-header error.

Test plan

  • Confirm a build with this pin restored successfully compiles MaskedAssignImageFilter from the SimpleITKFilters remote module on release-5.4
  • Alternatively, consider backporting ENH: Add MaskedAssignImageFilter to ITKImageIntensity #6542 directly instead of reverting the pin, as the more complete long-term fix

🤖 Generated with Claude Code

34853cf ("Update remote-module pins toward buildable convergence
with main") advanced the ITKSimpleITKFilters remote-module pin to
372ab10343d, which removes MaskedAssignImageFilter now that it has
graduated to ITKImageIntensity core (ITKSimpleITKFilters#35,
InsightSoftwareConsortium#6542). InsightSoftwareConsortium#6542 was merged only to main
and has not been backported to release-5.4, so on release-5.4
itkMaskedAssignImageFilter.h no longer exists anywhere: removed from
the remote module, not yet added to core.

Revert this single pin to the last commit that still contains the
filter, restoring buildability of release-5.4 until InsightSoftwareConsortium#6542 is
backported.

Found via SimpleITK/SimpleITK#2674, which pins ITK_GIT_TAG to
release-5.4 in one CI matrix job and fails to compile
sitkMaskedAssignImageFilter.cxx with a missing-header error.
@github-actions github-actions Bot added type:Compiler Compiler support or related warnings area:Remotes Issues affecting the Remote module labels Aug 28, 2026
@blowekamp
blowekamp requested a review from hjmjohnson August 28, 2026 21:39
@blowekamp

Copy link
Copy Markdown
Member Author

PR #6688 may have been a little aggressive with update to all the repo modules while we don't have good testing infrastructure them.

@blowekamp
blowekamp marked this pull request as ready for review August 28, 2026 21:42
@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Restores the SimpleITKFilters remote-module pin to the intended release-5.4 revision. An isolated checkout fetched and resolved the updated immutable commit bb896868fc6480835495d0da4356d5db009592a6, where the expected module manifest and CMake entrypoint are present. No defects were found.

T-Rex validation blocked

The enabled-module configure and build could not run because the cmake tool is not installed. This prevented compilation validation of Module_SimpleITKFilters=ON.

Confidence Score: 5/5

The updated remote revision resolves successfully and no merge-blocking defect was found.

The isolated-worktree check confirmed that both the previous and updated revisions can be fetched and checked out exactly, with the expected module files available. The unavailable CMake tool limited compilation coverage but did not produce a defect.

Files Needing Attention: No files need changes. Modules/Remote/SimpleITKFilters.remote.cmake should receive the normal enabled-module configure/build check when CMake is available.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex authored an executable review script that creates isolated worktrees and performs exact-SHA Git fetch and checkout steps to reproduce the pin review procedure.
  • The before-run output showed the old pin resolved to commit 372ab10343df104063ca6a55eb72f7d5fe830d7b, confirming baseline remote resolution.
  • The after-run output showed the new pin resolved to bb896868fc6480835495d0da4356d5db009592a6, confirming the changed remote pin is available and has a manifest/CMake entrypoint.
  • The configure/build attempt reported that CMake is unavailable, blocking compilation-level validation.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "COMP: Restore SimpleITKFilters pin remov..." | Re-trigger Greptile

@blowekamp
blowekamp merged commit e125751 into InsightSoftwareConsortium:release-5.4 Aug 29, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Remotes Issues affecting the Remote module type:Compiler Compiler support or related warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants