Fix: Blocked channels still visible in search results#82
Open
BaselGamal0 wants to merge 1 commit into
Open
Conversation
The applyBlocking() method only checked StreamInfoItem against the blocked channel list. ChannelInfoItem and PlaylistInfoItem were never filtered, allowing blocked channels and their playlists to appear in search results. Extended the channel filter check to also remove: - ChannelInfoItem (matched by getName()) - PlaylistInfoItem (matched by getUploaderName())
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a channel is added to the block list (Settings -> Filter -> Filter by Channel), searching for the channel still shows its icon/card and playlists in search results.
Root Cause
The
applyBlocking()method inInfoItemsCollectorwas only checkingStreamInfoItem(videos) against the blocked channel list.ChannelInfoItem(channels) andPlaylistInfoItem(playlists) were ignored.Fix
Extended the channel filtering check in
applyBlocking()to also filter out:ChannelInfoItem(matched by name)PlaylistInfoItem(matched by uploader name)