Test 45782: Prevent manual scoring of unfinished attempts

[matheuszych]

See: https://mantis.ilias.de/view.php?id=45782

Manual scoring by question allowed opening the scoring UI for attempts that were still in progress. ScoringByQuestionTableBinder now skips unfinished attempts when composing table rows. TestScoringByQuestionGUI verifies the attempt is finished via getAttemptOverviewFor before calling getAnswerDetail; otherwise an exception is thrown.

/cc @thojou

[dsstrassner]

@kergomard please review!

[jweber-unibe]

Possibly I am just mistaken – but I fail to see the direct connection of this PR to the mentioned issue, implied by the Mantis link. 🤔
The issue report in itself has nothing to do with manual scoring but deals with the status display in the 'Participants' table.

(... just in case this remark has any relevance at all 😉)

[kergomard]

Thank you very much for the PR @matheuszych

First: I would echo the comment from @jweber-unibe : Could you tell me what problem you are trying to solve and where the corresponding behavior is specified? A link to an issue where @dsstrassner agreed that this is the right way to go, would completely suffice.

Then:

• This looks potentially unnecessarily expensive we somehow retrieve a whole dataset to get one single small information and simply rely on the fact that it will be cached. If we think we need this information: Shouldn't it be available in a dataset we will really need at these points?
• This will look completely different for ILIAS 11, though, right? Could you please provide a PR for ILIAS 11. If this PR can be made more elegant, we can stick to the solution here for ILIAS 10 as we would have an immediate exit ramp.

Thank you very much again and best,
@kergomard

[dsstrassner]

@kergomard & @matheuszych I think @matheuszych should report about this in the TechSquad.

[jweber-unibe]

Relating to my comment from above (Apr 30) ...

Possibly I am just mistaken – but I fail to see the direct connection of this PR to the mentioned issue, implied by the Mantis link. 🤔 The issue report in itself has nothing to do with manual scoring but deals with the status display in the 'Participants' table.

→ Possibly this PR was rather meant to point to https://mantis.ilias.de/view.php?id=44871?!
The PR's description fits much better there ...

(Maybe(?!) also of interest in this context: https://mantis.ilias.de/view.php?id=48278 / #12028)

[matheuszych]

Hello @jweber-unibe and @kergomard,

First of all, thank you for your patience! I believe I now know the reason behind these changes.

Before going into that, I would like to point out that this is not related to Mantis issue 44871, as the timelines do not match. This Mantis issue had already been closed long before I attempted to fix this issue.

While going through our internal notes, I came across a comment of my own that provides much of the explanation:

... This fix is technically not really for that Mantis issue either. ...

However, this does not mean that the PR should be abandoned, as it consists of two separate commits:

• Test: Prevent manual scoring of unfinished attempts
• Test: Add participant table attempt view modes

The second commit is directly related to Stephan’s comment in Mantis issue 45782 and is therefore still relevant in my opinion.

Although the first commit is not directly related to this issue, I would still like it to be considered as a possible change to ILIAS. In my opinion, grading a test pass should not be possible before the test taker has fully completed it, as they can still change their answers. Consequently, the grading may not be accurate. Please correct me if I am mistaken. Otherwise, I would be happy to open a separate Mantis report and move this commit to a separate PR.

I should have provided this explanation from the beginning to avoid any confusion. I apologize for that.

My next step will probably be to extract the first commit from this PR.

Best regards,
@mzych