UIComponent: Add PHP code for glyphs: select, unselect & clear - #10829
Open
lscharmer wants to merge 1 commit into
Open
UIComponent: Add PHP code for glyphs: select, unselect & clear#10829lscharmer wants to merge 1 commit into
lscharmer wants to merge 1 commit into
Conversation
BettyFromHH
added
the
css/html
thibsy
requested changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Hi @lscharmer,
Thx a lot for your contribution to the UI framework!
Please implement the following changes:
-
ILIAS\UI\Component\Symbol\Glyph\Factory: please populate these methods on the public interface as well, alongside with one example for each one of them. I don't want Glyph components to be internal.
Kind regards,
@thibsy (as UI coordinator)
lscharmer
force-pushed
the
12/select-glyph-php-part
branch
from
September 8, 2026 12:43
3d092c6 to
13cd790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the existing glyphs
select,unselect&clearto the corresponding code places, so they can be used within PHP.This issue implements one part of: https://mantis.ilias.de/view.php?id=40579
A second part to resolve the mantis issue will follow.