-
Notifications
You must be signed in to change notification settings - Fork 12
Upgrade EdgeZero to the deploy-actions branch #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aram356
wants to merge
10
commits into
main
Choose a base branch
from
worktree-edgezero-316-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+306
−28
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bc13f27
Upgrade EdgeZero to the deploy-actions branch
aram356 e4a8f37
Merge branch 'main' into worktree-edgezero-316-upgrade
aram356 96dd1f7
Merge branch 'main' into worktree-edgezero-316-upgrade
aram356 1e7b4ca
Merge remote-tracking branch 'origin/main' into worktree-edgezero-316…
aram356 b743345
Update EdgeZero to latest deploy-actions branch tip
aram356 5420390
Sync EdgeZero to latest deploy-actions tip and adopt config gc
aram356 b23f270
Merge remote-tracking branch 'origin/main' into worktree-edgezero-316…
aram356 fe5767e
Sync EdgeZero to deploy-actions tip 5f3d648c
aram356 fc969ce
Merge branch 'main' into worktree-edgezero-316-upgrade
aram356 46b7052
Merge branch 'main' into worktree-edgezero-316-upgrade
aram356 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 wrench — Six deps now point at a live branch of an unmerged upstream PR, and this PR is no longer a draft.
Verified against the upstream API:
stackpop/edgezero#316isstate: open,merged: false. This PR reportsisDraft: falseandmergeable: MERGEABLE, so nothing mechanically prevents merging abranch =ref intomain.Cargo.lockcurrently pins5f3d648c, but that pin is only as durable as the lockfile — anycargo update, or acargo install/fresh resolve that does not pass--locked, silently retargets whatever the branch tip is at that moment. A force-push or branch deletion upstream breaks the fetch outright.The PR body already flags this, but the PR state doesn't match the caveat.
Fix — either flip back to draft until #316 merges and a tag is cut, or pin immutably in the meantime:
A
revgives the same code as today's lock while making the reference immutable, so the repin-before-merge step becomesrev→tagrather than "remember not to merge this."