Add native secret-store config resolution - #1036
Draft
ChristianPavilonis wants to merge 2 commits into
Draft
Conversation
ChristianPavilonis
marked this pull request as draft
August 18, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/trusted-server-core/src/config.rscrates/trusted-server-core/src/secret_resolution.rscrates/trusted-server-core/src/config_payload.rs/settings.rscrates/trusted-server-adapter-{fastly,axum,cloudflare,spin}/crates/trusted-server-integration-tests/trusted-server.example.toml/.env.example/docs/guide/Cargo.toml/Cargo.lockCloses
Closes #684
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest run(not applicable; no JS changes)cd crates/trusted-server-js/lib && npm run format(not applicable; no JS changes)cd docs && npm run format(targeted changed-doc checks pass; full check has unrelated pre-existing failures)cargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servecargo test-cloudflare,cargo test-spin, adapter parity tests, Cloudflare/Spin WASM checks and Clippy targets, CLI validation, core tests, targeted docs formatting, andgit diff --check.Checklist
unwrap()in production code — useexpect("should ...")