Inline & strip down ExpressionShortcuts - #669
Open
TheConstructor wants to merge 2 commits into
Open
Conversation
This elemiminates all NRT-warnings in the solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we now have NRT and I really like it! But currently we get some warnings during the build, mostly related to ExpressionShortcuts. I looked into it and created oformaniuk/ExpressionShortcuts#5, that would allow to get rid of the NRT-warnings.
Over a month has passed and the last change to any branch of that repository is currently 6 years old.
Now this library doesn't use everything of ExpressionShortcuts, and so I started out by adding an annotated copy of ExpressionShortcuts and then tried to strip out as many unnecessary features as possible, to not introduce a higher maintenance burden than necessary. I also tried to simplify a bunch of things - 6 years is quite some time in programming after all - and judging by the tests I may have been successful.