Skip to content

Add a dropdown for resource selection and adopt it in the 'Image' node - #4543

Merged
Keavon merged 4 commits into
masterfrom
resource-picker
Sep 19, 2026
Merged

Keavon merged 4 commits into
masterfrom
resource-picker

Conversation

@Keavon

@Keavon Keavon commented Sep 16, 2026 •

Copy link
Copy Markdown
Member
image

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 19 files

Confidence score: 4/5

  • In frontend/src/utility-functions/files.ts, raster drops in browsers or CEF WebViews lacking Blob.bytes() can throw before the image is inserted; use new Uint8Array(await file.arrayBuffer()) to preserve compatibility.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="frontend/src/utility-functions/files.ts">

<violation number="1" location="frontend/src/utility-functions/files.ts:96">
P2: When a raster file is dropped in a browser or CEF WebView without `Blob.bytes()`, this new branch throws before inserting the image. Use `new Uint8Array(await file.arrayBuffer())` instead.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/nodes/raster/src/std_nodes.rs
Comment thread editor/src/messages/portfolio/document/node_graph/node_properties.rs Outdated
Comment thread editor/src/messages/portfolio/utility_types.rs Outdated
Comment thread frontend/src/utility-functions/files.ts
Comment thread editor/src/messages/portfolio/utility_types.rs Outdated
Comment thread editor/src/messages/frontend/frontend_message.rs Outdated
@timon-schelling

timon-schelling commented Sep 16, 2026 •

Copy link
Copy Markdown
Member
  1. desktop is completely missing
  2. uploading an image should be one unified path. not two separate ones. the pasting an image branch should also use this.
  3. should be separated out into a resource dialog/management handler, especially if you are planning to add other file types soon. (currently feels like duct tape together into the document handler).
  4. could you make this a stack with other things that depend on it (other File types mostly)?
  5. resources get garbage collected when reloading the page (because the are removed from the history)

@timon-schelling
timon-schelling marked this pull request as draft September 16, 2026 15:10
@Keavon Keavon changed the title Add a dropdown for resource selection and adopt it in the Image node Add a dropdown for resource selection and adopt it in the 'Image' node Sep 17, 2026
@Keavon
Keavon marked this pull request as ready for review September 17, 2026 07:39

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 33 files

Requires human review: Auto-approval blocked because this review re-detected 3 unresolved issues already reported by Cubic.

Re-trigger cubic

Comment thread editor/src/messages/clipboard/clipboard_message_handler.rs
Comment thread frontend/wrapper/src/editor_wrapper.rs
Comment thread editor/src/messages/portfolio/document/node_graph/node_properties.rs Outdated
Comment thread editor/src/messages/portfolio/resource_upload/utility_types.rs
Comment thread editor/src/messages/portfolio/resource_upload/resource_upload_message.rs Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 32 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 3 unresolved issues already reported by Cubic.

Re-trigger cubic

Comment thread editor/src/messages/portfolio/portfolio_message_handler.rs Outdated
…very non-font resource in the picker, and link sibling message docs
@timon-schelling
timon-schelling added this pull request to stack #4549 September 19, 2026 00:56
@Keavon
Keavon merged commit f90bef1 into master Sep 19, 2026
11 checks passed
@Keavon
Keavon deleted the resource-picker branch September 19, 2026 01:14

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 2508fef2 Deployed Sep 17, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants