Improve MATLAB bindings (SSMC pipeline, type minimization, allocator safety, tests)#25
Open
BenBrock wants to merge 46 commits into
Open
Improve MATLAB bindings (SSMC pipeline, type minimization, allocator safety, tests)#25BenBrock wants to merge 46 commits into
BenBrock wants to merge 46 commits into
Conversation
…ders. `binsparse_all.h` includes everything.
Base automatically changed from
feature/matlab-bindings
to
feature/refactor-error-handling
July 15, 2026 19:46
Remove the six stale per-file compile scripts (superseded by build_matlab_bindings / build_octave_bindings and broken against the static-cJSON build) and the root Makefile scaffold. Clean debug leftovers out of build_matlab_bindings.m: restore the dead 'verbose' flag, drop the always-on -g, remove variable echoes and stale comments, and guard rpath on non-Unix platforms. Move the SPDX header below the help comment block in the bindings .m files: MATLAB's help shows the first comment block in a file, so a leading SPDX block hid the real help text and filled Contents.m with license boilerplate. Replace the FIXME help stubs for binsparse_read, binsparse_write, and binsparse_from_ssmc with real documentation, hand-write Contents.m, and bring the README file table and examples in line with the actual behavior. Also remove a dead nnz assignment in matlab_bsp_helpers.h and replace the static lock guards with mexIsLocked(), with comments explaining why the HDF5-using MEX files stay locked. All six MEX functions rebuild cleanly and all eight binding tests pass in MATLAB R2025b. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
introduced comprehensive tests.
Key changes
Files touched (high level)
Contents.m, build scripts
Notes
Testing