Skip to content

feat(backend): implement CategorizedSummaryVisitor on RSS visitor with rich sections (#2622)#2634

Open
jcscottiii wants to merge 1 commit into
feat/all-saved-search-categorizer-interfacefrom
feat/all-saved-search-rss-visitor-impl
Open

feat(backend): implement CategorizedSummaryVisitor on RSS visitor with rich sections (#2622)#2634
jcscottiii wants to merge 1 commit into
feat/all-saved-search-categorizer-interfacefrom
feat/all-saved-search-rss-visitor-impl

Conversation

@jcscottiii

@jcscottiii jcscottiii commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Implements CategorizedSummaryVisitor on rssVisitor in backend/pkg/httpserver to handle double dispatch for all feature change categories and error banners.

  • Implements CategorizedSummaryVisitor on rssVisitor in backend/pkg/httpserver.
  • Updates RSSItemData and HTML templates to render dedicated sections for Changed, Moved/Renamed, Split, and Deleted features alongside Added and Removed.
  • Adds 4 disk-backed golden snapshot files in backend/pkg/httpserver/testdata/ (rss_description.golden.html, rss_query_error.golden.html, rss_resolved_query_error.golden.html, rss_combined_errors_and_features.golden.html) and converts rss_renderer_test.go to use cmp.Diff with -update flag support.
  • Adds TestRSSVisitor_FeatureCategories, TestRSSVisitor_QueryErrors_RenderMessage, TestRSSVisitor_TriggerFiltering, TestRSSVisitor_NilPointerGuards, and TestRSSVisitor_CombinedErrorsAndFeatures unit tests.

Fixes #2622 (PR 2/5)

CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1
TAG=agy

@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-rss-visitor-impl branch from 6c9623f to cf06012 Compare July 21, 2026 20:05
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-categorizer-interface branch from 7cdc1d1 to 488e7a1 Compare July 21, 2026 20:05
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-rss-visitor-impl branch from cf06012 to fd0471d Compare July 21, 2026 20:10
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-categorizer-interface branch from 488e7a1 to 9813fe1 Compare July 21, 2026 20:10
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-rss-visitor-impl branch from fd0471d to 60a4463 Compare July 21, 2026 21:10
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-categorizer-interface branch 2 times, most recently from 77e657e to ee74103 Compare July 21, 2026 21:43
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-rss-visitor-impl branch 2 times, most recently from b1995de to ea868e5 Compare July 22, 2026 14:01
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-categorizer-interface branch from ee74103 to ad1d254 Compare July 22, 2026 14:01
…h rich sections (#2622)

Implement the CategorizedSummaryVisitor interface on rssVisitor for structured RSS feed payload generation.

- Implement CategorizedSummaryVisitor on rssVisitor in backend/pkg/httpserver to handle double dispatch for all feature change categories and error banners.
- Update RSSItemData and HTML templates to render dedicated sections for Changed, Moved/Renamed, Split, and Deleted features alongside Added and Removed.
- Add unit test suite (TestRSSVisitor_FeatureCategories) verifying category routing and RSS description rendering.

CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1
TAG=agy
@jcscottiii
jcscottiii force-pushed the feat/all-saved-search-rss-visitor-impl branch from ea868e5 to dce0111 Compare July 22, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant