Skip to content

feat!: [FEEDS-1763] regenerate OpenAPI client - #284

Closed
itsmeadi wants to merge 1 commit into
mainfrom
FEEDS-1763
Closed

itsmeadi wants to merge 1 commit into
mainfrom
FEEDS-1763

Conversation

@itsmeadi

@itsmeadi itsmeadi commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Regenerates the OpenAPI client from current chat specs (chat branch feature/feeds-0-generate-sdk-openapi-skill).
  • Adds feeds models (ActivityMarksConfig, FeedGroupScope, …) and changes campaign update/stop response types.

Test plan

  • CI generate/lint/integration on this PR
  • Confirm campaign UpdateCampaign/StopCampaign callers compile against the new response types

Made with Cursor

Summary by CodeRabbit

  • New Features

    • Channel deletion now supports an optional setting to skip message truncation.
    • Rate-limit queries now support separate Unity Desktop and Unity Console filters.
  • Refactor

    • Reformatted chat, feeds, moderation, and video client interfaces for improved consistency and readability.
    • Preserved existing API behavior, endpoints, parameters, response handling, and error behavior across the affected clients.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 48e5c7cd-32bc-4088-801d-3ff0b0a04352

📥 Commits

Reviewing files that changed from the base of the PR and between d665740 and e86d668.

📒 Files selected for processing (15)
  • getstream/chat/async_channel.py
  • getstream/chat/async_rest_client.py
  • getstream/chat/channel.py
  • getstream/chat/rest_client.py
  • getstream/common/async_rest_client.py
  • getstream/common/rest_client.py
  • getstream/feeds/feeds.py
  • getstream/feeds/rest_client.py
  • getstream/models/__init__.py
  • getstream/moderation/async_rest_client.py
  • getstream/moderation/rest_client.py
  • getstream/video/async_call.py
  • getstream/video/async_rest_client.py
  • getstream/video/call.py
  • getstream/video/rest_client.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request reformats chat, feed, moderation, and video clients. It adds skip_truncate to channel deletion and adds Unity desktop and console filters to rate-limit requests.

Changes

API client updates

Layer / File(s) Summary
Chat channel deletion options
getstream/chat/async_channel.py, getstream/chat/channel.py
Channel deletion accepts and forwards the optional skip_truncate parameter. Other channel methods are reformatted without behavior changes.
Common rate-limit query parameters
getstream/common/async_rest_client.py, getstream/common/rest_client.py
get_rate_limits accepts and forwards unity_desktop and unity_console. Other common client methods are reformatted without behavior changes.
Feed and moderation client formatting
getstream/feeds/feeds.py, getstream/moderation/*
Feed and moderation methods use condensed signatures and calls. Parameters, endpoints, request data, and control flow remain unchanged.
Video wrapper and REST client formatting
getstream/video/*
Video call wrappers and REST clients use condensed signatures and calls. Endpoints, parameters, request data, and return types remain unchanged.

Priority: ⬇️ Low — Defer this generated-client refresh because it is primarily formatting with limited optional API parameter and response-type changes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to e86d6

This updates generated client formatting and adds optional channel-deletion and Unity rate-limit filters without identified behavior regressions. The change is ready to merge.

Suggested reviewers: mogita

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 1.05% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 573 functions across 11 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: regenerating the OpenAPI client. The FEEDS-1763 reference and feature marker provide useful context.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch FEEDS-1763

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@itsmeadi itsmeadi closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant