Conversation
A single polar axis is a sector so thin that its bounding box has a width but no height. Rotating it by 90 degrees swaps the two and broke both the scale and the annotations: * gmtmap_setinfo matched -JP<size> to the map width, which for a sector standing on end is nothing but round-off, so -JP12c+t90 produced a plot 12 x 3437746 cm. It now checks the dimension it was asked to match and falls back to the other one when the first is under 0.01 % of it, with a warning (and a pointer to -Jp<scale> for polar plots). A fully degenerate map no longer divides by zero. * n_lon_nodes/n_lat_nodes are derived from the map dimensions and rounded down to zero for a map with no width, so the boundary-walking loops in gmtlib_map_latcross/gmtlib_map_loncross never ran and no ticks or annotations were placed. The three places that derive them now floor them at 2. Adds test/psbasemap/polar_thin_sector.sh and documents the meaning of the -JP size for sectors, plus the -Jp recipe for radar plots. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZPAjvoG9oCgbMMbenuV8c
Member
|
I tested it and the test works fine. But I run the command of #7059 and I got this figure
I suspect that the origin of the second axis should be at 0.0. |
Member
Author
|
Damn it (thanks for testing). |
Member
Member
Author
|
It smells like the thing has tailored the code to comply with the example given and not with a general solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



A single polar axis is a sector so thin that its bounding box has a width but no height. Rotating it by 90 degrees swaps the two and broke both the scale and the annotations:
Adds test/psbasemap/polar_thin_sector.sh and documents the meaning of the -JP size for sectors, plus the -Jp recipe for radar plots.
Fix #7059
Supersedes #9131
Assisted-by: GPT Terra + Claude Opus 5.0