Conversation
When a vector symbol's fill was set via -SV...+g<fill> (rather than via -G<fill>), gmt_add_legend_item() was only ever passed Ctrl->G.fill, which stays at its unset sentinel since -G was never given. This caused the auto-legend entry (-l) to be written with no fill, so the vector head in the legend rendered unfilled even though the same vector drawn on the map was correctly filled via S.v.fill. Fixes #9167
psxyz.c had the identical issue as psxy.c (fixed in the previous commit): Ctrl->G.fill was never synced with S.v.fill when the vector head fill came from +g<fill> instead of -G<fill>, so gmt_add_legend_item() wrote an unfilled vector head into the auto-legend entry. Related to #9167
Esteban82
added
add-changelog
Esteban82
marked this pull request as ready for review
August 29, 2026 16:49
Member
Author
|
Could you test this @mkononets? |
|
No, unfortunately, I cannot promise testing this now or any time soon. Swallowed up by preparations for field measurements for a new project. |
joa-quim
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a vector symbol's head fill is set via the symbol's own
+g<fill>modifier, the sample vector shown in the auto-legend (-l) is drawn unfilled. This PR fixes this inpsxy.candpsxyz.c.Tested with:
Fixes #9167
Implemented with Claude Sonnet 5 (Claude Code).