psevents: Allow -R to be determined automatically from input data - #9163
Merged
Conversation
Change THIS_MODULE_NEEDS from "JR" to "Jd" so that when -R is not given, gmtinit_determine_R_option_from_data() / gmtinit_set_missing_R_from_datasets() in gmt_init.c will compute the bounding box from the input dataset (equivalent to running gmtinfo on it) and inject it before the module parses options. This matches the existing behavior of the other plotting modules that read dataset input, such as psxy, psxyz, pscontour, psclip, pswiggle, psternary and psmask, all of which already use "Jd". Assisted-by: Claude Sonnet 5 (Medium effort)
Esteban82
added
enhancement
joa-quim
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with:
printf "1 1 3\n0 0 3\n" | gmt events -T3 -Gred -Sc0.1c -JX3c -Ba -Ra -png lixoPreviously this failed with
Must specify -Roption since-Rahad no way to determine the region forpsevents; now it correctly infers-Rfrom the input data.Assisted-by: Claude Sonnet 5 (Medium effort)