Issue 8235. Certain -I -R in grdlandmask create horizontal bands - #9162
Merged
Conversation
The candidate column range of a shoreline polygon came with two fallbacks: a col_min above nx1 was reset to 0, and a col_max at or below 0, or below col_min, was reset to nx1. With -I...+n the node counts often give non-terminating grid spacings, so a polygon bound can round just outside the valid range - and the fallback then turned that near miss into the full grid width, ran the winding test over unrelated nodes and produced the mask artifacts in the report. Global grids keep the old wrap-around handling. For a non-global grid the interval is now clipped to [0,nx1] when it really overlaps the grid, and the polygon is skipped when it does not. Shoreline classification is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
joa-quim
added
the
AI-assisted
Member
|
It didn't work form me. I got the same figure. |
Member
Author
|
Hmm, I had a quite long fight with Claude and it seemed to work at the end. Will recheck but this is high tokens consuming for a minor important bug. |
Member
Author
|
Please try again. I had forgotten to commit the latest changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8235
Assisted-by: Claude Opus 5.0