Skip to content

fix(ui): align page headers and action cards with the design system - #2924

Merged
kev1n77 merged 1 commit into
GCWing:mainfrom
kev1n77:fmy/ui-main
Sep 9, 2026
Merged

fix(ui): align page headers and action cards with the design system#2924
kev1n77 merged 1 commit into
GCWing:mainfrom
kev1n77:fmy/ui-main

Conversation

@kev1n77

@kev1n77 kev1n77 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Give welcome and settings page headers distinct typography, using the shared PageHeader in the welcome screen.
  • Remove redundant settings-header typography and spacing overrides.
  • Align action cards with the design: a translucent 3% background in light mode, 12px padding, 15px semibold titles, and clearer 13px descriptions.
  • Use outlines instead of borders to avoid inflating card geometry.
  • Update Design Lab previews and preserve legacy Appearance background overrides.

Type and Areas

Type: Bug fix / UI/UX

Areas: Web UI, shared UI components, design tokens, themes, Appearance compatibility, Design Lab.

Motivation / Impact

Welcome and settings headers previously used inconsistent typography, while action cards had mismatched spacing and overly muted descriptions.

This change gives page introductions and entry cards consistent visual hierarchy across product screens and Lab previews. Long content remains compatible with trailing actions, and existing custom Appearance backgrounds retain their precedence.

Verification

Recorded validation for this patch:

  • pnpm run design-system:check — passed, including component checks and the Lab production build.
  • pnpm run check:web — passed, including theme audits and TypeScript checks.
  • Focused Appearance regression tests — 2 files, 19 tests passed, covering legacy payload round trips and explicit new-token precedence.
  • Native Windows desktop inspection covered settings headers and global-search entry cards.

Checks were not rerun while drafting this description. Other themes, narrow layouts, and remote interaction scenarios remain pending visual verification.

Reviewer Notes

  • Welcome headers use the display variant; settings headers use md.
  • Action-card sizes remain distinct: sm and md retain their respective minimum heights.
  • The new card-background token preserves legacy Appearance overrides in both root and chrome scopes.
  • No backend protocols or persisted data shapes change.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

Distinguish settings and welcome heading typography, use a translucent 3% entry-card surface, and align card padding and text without border-driven height inflation. Remove redundant ConfigPageHeader typography and preview long descriptions with sibling actions in Lab.

Preserve legacy Appearance background overrides in root and chrome, including old-payload round trips and explicit new-token precedence.

Validation: design-system:check; 19 focused Appearance tests; check:web (all theme audits and type checking); final Lab production build. Native Windows desktop settings and global-search entry cards inspected. Other themes, narrow layouts, and four remote scenarios were not interactively verified.
@kev1n77
kev1n77 merged commit 57ceb3e into GCWing:main Sep 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant