fix: replace JSX.Element with React.ReactElement for React 19 compatibility

[tyler-reitz]

Problem

Since React 19 removed JSX.Element from the global JSX namespace, components in reactfire that return JSX.Element no longer type-check:

Type error: 'AuthProvider' cannot be used as a JSX component.
  Its type '(props: PropsWithChildren<{ sdk: Auth; }>) => Element' is not a valid JSX element type.
    Type 'Element' is not assignable to type 'ReactNode | Promise<ReactNode>'.

Fix

Replace all JSX.Element return type annotations with React.ReactElement, which is the equivalent type and works correctly with both React 18 and React 19 types. This is not a breaking change — JSX.Element was always an alias for React.ReactElement<any, any>.

Changed in 4 places:

• src/sdk.tsx — SdkProvider (covers AuthProvider and all other SDK providers)
• src/auth.tsx — AuthCheck
• src/performance.tsx — SuspenseWithPerf
• src/storage.tsx — INTERNALStorageImage return type and placeHolder prop type

Fixes #637

[gemini-code-assist]

Code Review

This pull request updates several component return types and prop types from JSX.Element to React.ReactElement across auth.tsx, performance.tsx, sdk.tsx, and storage.tsx. The review feedback suggests using React.ReactNode instead of React.ReactElement for the placeHolder prop in storage.tsx to allow for more flexible types like strings or numbers, and consequently updating the return type of INTERNALStorageImage to React.ReactNode as well.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[armando-navarro]

The PR description might be a little misleading now with regard to the storage change, which becomes the squash merge commit body. Very minor, but might want to update that before merging.

One possible follow-up issue I found is that CI only type-checks against @types/react 18, so nothing stops a global JSX.Element from creeping back in and re-breaking React 19 consumers. A small CI step that packs the build and runs tsc over a fixture with @types/react@19 (and 18) would lock this fix in.

Approving the PR.