Skip to content

captureMetrics doe not seem to be working anymore. #180

Description

@marcaaron

Reproduction:

  • Add captureMetrics: true in Onyx.init()
  • Observe error in JS console
app-c63af0784ac898b80ef3.bundle.js:33823 Uncaught TypeError: getAllKeys is not a function
    at addAllSafeEvictionKeysToRecentlyAccessedList (web.development.js?d0e7:698:1)
    at Object.init (web.development.js?d0e7:1418:1)
    at __WEBPACK_DEFAULT_EXPORT__ (index.js?ce78:22:5)
    at eval (index.js?41f5:12:19)
    at ./index.js (app-c63af0784ac898b80ef3.bundle.js:7140:1)
    at __webpack_require__ (app-c63af0784ac898b80ef3.bundle.js:33820:33)
    at app-c63af0784ac898b80ef3.bundle.js:34910:37
    at app-c63af0784ac898b80ef3.bundle.js:34912:12

I think maybe the lazy import of this code just doesn't work because we are using a bundle that is already built, but not entirely sure

const decorate = require('./metrics');

I think we can just include this in all dev bundles

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions