Fix transition animation flicker through ColourSchemeButton#251
Open
zoharma wants to merge 2 commits into
Open
Fix transition animation flicker through ColourSchemeButton#251zoharma wants to merge 2 commits into
zoharma wants to merge 2 commits into
Conversation
zoharma
changed the title
NKatti2011
requested changes
Jul 10, 2026
NKatti2011
left a comment
NKatti2011
left a comment
Collaborator
There was a problem hiding this comment.
Not sure we should have the "temporary" solution that may affect other components unintentionally, or pause unrelated animations, since you're setting a global style rule through a component. This change should live at the theme provider / colour scheme context level instead. Please add debounce for double-click instances, and clear timeout on rapid clicks. The 250ms timeout is arbitrary and may cause intermittent issues in other apps depending on tree size.
zoharma
force-pushed
the
zma/fix-ColourSchemeButton-mode-flash
branch
from
cafc2c9 to
38dc4aa
Compare
zoharma
force-pushed
the
zma/fix-ColourSchemeButton-mode-flash
branch
from
38dc4aa to
cb1ad58
Compare
zoharma
force-pushed
the
zma/fix-ColourSchemeButton-mode-flash
branch
from
cb1ad58 to
18efe94
Compare
Contributor
Author
|
@NKatti2011 Have moved the colour scheme transition suppression to ThemeProvider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching between light and dark mode caused a noticeable flicker as components transitioned before the new colour scheme had fully applied. This happened in internal components such as Chips and external ones such as Material React Table.
This fix adds a temporary
ds-mode-changingclass during colour scheme changes to suppress CSS transitions and animations until the new theme has been applied, reducing flicker during mode switching.The CSS and the class were added to the
ColourSchemeButtondirectly.