Skip to content

Making Estimate_Transmission Wrapper a standalone pipeline#373

Open
pjnaughton wants to merge 14 commits into
mainfrom
estimate_transmission_standalone_pipeline
Open

Making Estimate_Transmission Wrapper a standalone pipeline#373
pjnaughton wants to merge 14 commits into
mainfrom
estimate_transmission_standalone_pipeline

Conversation

@pjnaughton

Copy link
Copy Markdown
Collaborator

Moving the estimate_transmission outside of udc strategy and into its own processing pipeline. The trigger service now will only trigger for this pipeline and wait until a resolution estimate is present from any of the autoprocessing pipelines.

@pjnaughton pjnaughton requested a review from pblowey May 29, 2026 11:13
@pjnaughton pjnaughton self-assigned this May 29, 2026
Comment thread src/dlstbx/services/strategy.py
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/services/trigger.py
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/services/trigger.py Outdated
Comment thread src/dlstbx/wrapper/estimate_transmission.py Outdated
@pblowey

pblowey commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@pjnaughton just in case you're wondering, the review is for my own benefit. I'm not expecting you to go back and change things.

pblowey added 10 commits July 9, 2026 13:41
This allows params to be set directly in the recipe, as well as to be
read via ispyb_parameters.
Avoids potential keyerror for input recommended transmission and now
expects that if there is no recommended transmission, the key will not
exist. Value can only take float or list of float values. If a list is
provided, the first value will be used.
This file was changed inadvertently during a merge conflict resolution.
The changes here fix the errors introduced in the merge commit.
@pblowey

pblowey commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Changes made to tidy up the pipeline, including removing unnecessary database queries from the trigger function, putting transmission in the database in the format it wants. Will need SynchWeb changes to handle the display of the estimate transmission pipeline before this can be deployed. Currently it displays as a downstream processing job.

Idea would be to have the pipeline results simply display warning messages (like it is currently set up to do) but the warning message simply says the percentage countrate at the specified percentile, with warning level based on thresholds.

Also considering changing the name of the pipeline/wrapper. Estimate transmission is ambiguous in its naming and something along the lines of "countrate check" is more descriptive of what the pipeline is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants