Skip to content

Add Read Only Attenuator Motor Readout - #2203

Draft
CoePaul wants to merge 1 commit into
mainfrom
issue2202
Draft

CoePaul wants to merge 1 commit into
mainfrom
issue2202

Conversation

@CoePaul

@CoePaul CoePaul commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
  • Add wedge and wheel readout as separate StandardReadable:

    • so that loss of (usage of) any one component does not force a re-write of the source code / runtime error / long timeout when reading.
  • Offers each specific absorber the chance to read out its own position relatively quickly without needing to wait for any element which might not even be mounted,

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

* Add wedge and wheel readout as separate StandardReadable:
  - so that loss of (usage of) any one component does not force a
    re-write of the source code / runtime error / long timeout when reading.

* Offers each specific absorber the chance to read out its own position
  relatively quickly without needing to wait for any element which might not
  even be mounted,
@CoePaul CoePaul self-assigned this Sep 7, 2026
@CoePaul
CoePaul requested a review from noemifrisina September 7, 2026 17:29
@codecov

codecov Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.09%. Comparing base (7b8fff3) to head (4e4ec1e).

Files with missing lines Patch % Lines
...ess_controlled/read_only_attenuator_motor_squad.py 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   99.34%   99.09%   -0.25%     
==========================================
  Files         367      368       +1     
  Lines       14396    14431      +35     
==========================================
  Hits        14301    14301              
- Misses         95      130      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant