Conversation
* Add wedge and wheel readout as separate StandardReadable:
- so that loss of (usage of) any one component does not force a
re-write of the source code / runtime error / long timeout when reading.
* Offers each specific absorber the chance to read out its own position
relatively quickly without needing to wait for any element which might not
even be mounted,
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
- Coverage 99.34% 99.09% -0.25%
==========================================
Files 367 368 +1
Lines 14396 14431 +35
==========================================
Hits 14301 14301
- Misses 95 130 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wedge and wheel readout as separate StandardReadable:
Offers each specific absorber the chance to read out its own position relatively quickly without needing to wait for any element which might not even be mounted,
Fixes #ISSUE
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}