Skip to content

Add transmission module for I19 beamline devices - #2200

Open
CoePaul wants to merge 1 commit into
mainfrom
issue2199
Open

Add transmission module for I19 beamline devices#2200
CoePaul wants to merge 1 commit into
mainfrom
issue2199

Conversation

@CoePaul

@CoePaul CoePaul commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
  • Start with adding JSON validation for system specification JSON dict-like structure expectations

  • Pydantic BaseModel classes map sub-structures ( sub-dicts ) within the system description structure here adding JSON validation for energy_interval [ the range of x-ray energies (in keV ) over which an absorption curve is valid ] JSON validation for absorption fit curve parameters [ the scaling constant, roll-off vs energy and an optional residuals polynomial ]

Fixes #2199

Instructions to reviewer on how to test:

  1. Check criteria from issue # 2199 are met
  2. Confirm CI passes tests and linter is happy

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@CoePaul
CoePaul requested a review from a team as a code owner September 7, 2026 13:42
@CoePaul CoePaul linked an issue Sep 7, 2026 that may be closed by this pull request
@CoePaul CoePaul self-assigned this Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.34%. Comparing base (7b8fff3) to head (6ec9d9e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2200   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         367      370    +3     
  Lines       14396    14436   +40     
=======================================
+ Hits        14301    14341   +40     
  Misses         95       95           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CoePaul
CoePaul marked this pull request as draft September 7, 2026 14:23
@CoePaul
CoePaul force-pushed the issue2199 branch 2 times, most recently from 23f4527 to 702ddd2 Compare September 7, 2026 14:43
@CoePaul
CoePaul marked this pull request as ready for review September 7, 2026 14:43
* Start with adding JSON validation for system specification
  JSON dict-like structure expectations

* Pydantic BaseModel classes map sub-structures ( sub-dicts ) within
  the system description structure here adding
   JSON validation for energy_interval
   [ the range of x-ray energies (in keV ) over which an absorption curve is valid ]
   JSON validation for absorption fit curve parameters
   [ the scaling constant, roll-off vs energy and an optional residuals polynomial ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add transmission module for i19

1 participant