Skip to content

fix(sidebar): enhance node selection to show details for single nodes - #1235

Open
Maystern wants to merge 3 commits into
DeusData:mainfrom
Maystern:fix/sidebar-show-node-and-details
Open

fix(sidebar): enhance node selection to show details for single nodes#1235
Maystern wants to merge 3 commits into
DeusData:mainfrom
Maystern:fix/sidebar-show-node-and-details

Conversation

@Maystern

@Maystern Maystern commented Jul 23, 2026

Copy link
Copy Markdown

What does this PR do?

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects
    unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • New behavior is covered by a test (reproduce-first for bug fixes)

@Maystern
Maystern requested a review from DeusData as a code owner July 23, 2026 16:47
Signed-off-by: Maystern <12112910@mail.sustech.edu.cn>
@Maystern
Maystern force-pushed the fix/sidebar-show-node-and-details branch from c85c66d to 883d3b2 Compare July 23, 2026 16:58
@DeusData DeusData added the bug Something isn't working label Jul 24, 2026
@DeusData DeusData added this to the 0.9.1-rc milestone Jul 24, 2026
@DeusData DeusData added ux/behavior Display bugs, docs, adoption UX priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. labels Jul 24, 2026
@DeusData

Copy link
Copy Markdown
Owner

Thanks for addressing #1197. Two selection cases remain incorrect in this head. nodeIds.size === 1 does not distinguish a leaf from a directory containing one node, so a one-node directory opens details even though Sidebar passes no node for directories. Search results without file_path still pass an empty path and clear selection, while the new GraphNode callback argument is ignored. The patch also duplicates the existing handleNodeClick neighbor and camera behavior. Please route explicit leaf/search-node selection through one canonical node-selection handler and add RED tests for leaf click, one-node directory, search result without file_path, clear selection, and neighbor highlighting.

Signed-off-by: Maystern <12112910@mail.sustech.edu.cn>
@Maystern
Maystern force-pushed the fix/sidebar-show-node-and-details branch from d31f9ee to 2147732 Compare July 24, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. ux/behavior Display bugs, docs, adoption UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants