nix: Make project config consistent#204
Open
jisantuc wants to merge 7 commits into
Open
Conversation
jisantuc
force-pushed
the
nix/js/update-flake
branch
2 times, most recently
from
b90c222 to
a9d69a6
Compare
jisantuc
commented
Jun 7, 2026
Contributor
Author
There was a problem hiding this comment.
flake.lock tracks hashes of inputs like nixpkgs to make sure people using nix build with the same package sets. It's an essential file to be in version control.
* Make examples depend on granite version consistent with non-examples; non-examples want >= 0.6, examples wanted 0.6.* * Remove `flake.lock` from `.gitignore` -- this is an important file to have in version control; without it, reproducibility guarantees are out the window (since, if we're using `nixpkgs-*` as an input, without the `flake.lock`, the `nixpkgs-*` package set you use won't necessarily be the same `nixpkgs-*` package set that I use) * Add (almost) the rest of the dataframe-* packages to the package outputs / dev shell
jisantuc
force-pushed
the
nix/js/update-flake
branch
from
a9d69a6 to
3104fcc
Compare
Contributor
Author
|
CI failures are driven by missing |
jisantuc
commented
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
>= 0.6, examples wanted0.6.*flake.lockfrom.gitignore-- this is an important file to have in version control; without it, reproducibility guarantees are out the window (discovered when I got yelled at by nix about the hash being wrong for granite, which seemed like it should have been impossible)Notes
Testing
nix developin this branchcabal repl <any project except dataframe-fusion>