v0.18.1 - #184
Merged
Merged
Conversation
Node can queue ClientRequest writes before a socket is assigned. Passing a Uint8Array view over wasm memory lets a later memory.grow detach the queued buffer, which can throw from _flushOutput outside the transport retry path. Copy the request body into Node-owned memory for each attempt before writing it. The head is still parsed from the current wasm memory view and response handling is unchanged.
Overall package sizeSelf size: 30.17 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
gyuheon0h
approved these changes
Jul 20, 2026
bengl
added a commit
that referenced
this pull request
Aug 31, 2026
Node can queue ClientRequest writes before a socket is assigned. Passing a Uint8Array view over wasm memory lets a later memory.grow detach the queued buffer, which can throw from _flushOutput outside the transport retry path. Copy the request body into Node-owned memory for each attempt before writing it. The head is still parsed from the current wasm memory view and response handling is unchanged. This landed on the v0.x release branch in v0.18.1 but was never brought back to main, so main still writes the live wasm view. Refs: #184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release for the WASM HTTP transport request-body lifetime fix.
Includes:
Release follow-up for #182.