Skip to content

fix(tests): stabilize durable function tag test #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucaspimentel wants to merge 2 commits into from
Closed

fix(tests): stabilize durable function tag test #1356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
828e395
fix(tests): stabilize durable function tag test
lucaspimentel Sep 3, 2026
55d6331
fix(tests): remove remaining clock dependency from durable tag test
lucaspimentel Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions bottlecap/src/lifecycle/invocation/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,12 +2598,6 @@ mod tests {

// The durable tag is already known, so the metric must be emitted immediately
// instead of being held back.
let now: i64 = std::time::UNIX_EPOCH
.elapsed()
.expect("unable to poll clock, unrecoverable")
.as_secs()
.try_into()
.unwrap_or_default();
processor.on_invoke_event("req-1".to_string());
assert!(
matches!(
Expand All @@ -2617,23 +2611,30 @@ mod tests {
.runtime
.clone()
.expect("runtime should have been resolved by on_invoke_event");
let ts = (now / 10) * 10;
let expected_tags = dogstatsd::metric::SortedTags::parse(&format!(
"cold_start:true,durable_function:true,runtime:{runtime}"
))
.ok();
let entry = processor
// Flush returns every bucket, so there is no need to guess the metric's timestamp.
Comment thread
lucaspimentel marked this conversation as resolved.
let flushed = processor
.enhanced_metrics
.aggr_handle
.get_entry_by_id(
crate::metrics::enhanced::constants::INVOCATIONS_METRIC.into(),
expected_tags,
ts,
)
.flush()
.await
.unwrap();
let expected_tags = [
"cold_start:true".to_string(),
"durable_function:true".to_string(),
format!("runtime:{runtime}"),
];
let found = flushed
.distributions
.iter()
.flat_map(|payload| &payload.sketches)
.any(|sketch| {
&*sketch.metric == crate::metrics::enhanced::constants::INVOCATIONS_METRIC
&& expected_tags
.iter()
.all(|expected| sketch.tags.iter().any(|tag| &**tag == expected.as_str()))
});
assert!(
entry.is_some(),
found,
"Expected the invocation metric to carry the durable_function:true tag"
);
}
Expand Down
Loading