Skip to content

feat: add useProperSingularization option for model name singularization - #440

Merged
doron050 merged 2 commits into
DaredevilOSS:mainfrom
ballistic-booger:fix-singularization-logic
Aug 3, 2026
Merged

feat: add useProperSingularization option for model name singularization#440
doron050 merged 2 commits into
DaredevilOSS:mainfrom
ballistic-booger:fix-singularization-logic

Conversation

@ballistic-booger

Copy link
Copy Markdown
Contributor
  • add rule-based Singularize to StringExtensions (policies -> Policy, statuses -> Status, devices -> Device)
  • thread new opt-in flag through ToModelName callers in DataClassesGen, ModelsGen, CommonGen, DbDriver, EnumDbDriver
  • expose useProperSingularization in RawOptions/Options, default false to keep legacy TrimEnd('s') behavior
  • add ModelNameTests covering both legacy and proper singularization paths
  • document the option in README and docs/03_Usage.md
  • regenerate example request.json/request.message fixtures with the new option field

- add rule-based Singularize to StringExtensions (policies -> Policy, statuses -> Status, devices -> Device)
- thread new opt-in flag through ToModelName callers in DataClassesGen, ModelsGen, CommonGen, DbDriver, EnumDbDriver
- expose useProperSingularization in RawOptions/Options, default false to keep legacy TrimEnd('s') behavior
- add ModelNameTests covering both legacy and proper singularization paths
- document the option in README and docs/03_Usage.md
- regenerate example request.json/request.message fixtures with the new option field
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Release Assistant - Passed

All requirements satisfied.

Release Information:

  • Type: minor

This PR is ready to merge.

@ballistic-booger

Copy link
Copy Markdown
Contributor Author

Not sure what the release-assistant/requirements failure is referring to, when I open it up it looks like it passed.

@doron050

Copy link
Copy Markdown
Collaborator

Not sure what the release-assistant/requirements failure is referring to, when I open it up it looks like it passed.

It refers to this #440 (comment)

I added it so the release process will be easier

Tldr - add a label to the PR that represents your change type and this will be calculated into the next release version

@ballistic-booger

ballistic-booger commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Not sure what the release-assistant/requirements failure is referring to, when I open it up it looks like it passed.

It refers to this #440 (comment)

I added it so the release process will be easier

Tldr - add a label to the PR that represents your change type and this will be calculated into the next release version

Thanks for clarifying. I tried to add the label, but it seems like I don't have the permissions to do so. Neither the UI or gh let's me.

❯ gh pr edit 440 --repo DaredevilOSS/sqlc-gen-csharp --add-label minor
GraphQL: ballistic-booger does not have the correct permissions to execute AddLabelsToLabelable (addLabelsToLabelable)

@doron050

Copy link
Copy Markdown
Collaborator

gh pr edit 440 --repo DaredevilOSS/sqlc-gen-csharp --add-label minor
GraphQL: ballistic-booger does not have the correct permissions to execute AddLabelsToLabelable (addLabelsToLabelable)

Yes, you can't add labels from outside the repo... I didn't know about this limitation. I'll simply add the labels to PR's don't worry about it

Comment thread README.md Outdated
@doron050 doron050 added the minor New features or enhancements that are backward compatible. label Jul 28, 2026
- Revert changes made to the README.
@doron050
doron050 merged commit e8839a2 into DaredevilOSS:main Aug 3, 2026
9 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor New features or enhancements that are backward compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants