Accept grayscale JPEGs with non-1x1 sampling factors - #99
Open
illwieckz wants to merge 3 commits into
Open
Conversation
Some grayscale JPEG files contain non-1×1 sampling factors even though they only have a single luminance component. Treat these as grayscale JPEGs with 1×1 sampling instead of rejecting them. This fixes loading and converting flr_tmtl_bump.jpg from Xonotic.
Member
Author
|
A simple way to create a test sample is: |
illwieckz
force-pushed
the
illwieckz/normalize-jpg-sample
branch
from
August 5, 2026 01:37
d7e5aa2 to
40ede6f
Compare
illwieckz
force-pushed
the
illwieckz/normalize-jpg-sample
branch
3 times, most recently
from
August 5, 2026 02:25
dc152f2 to
d26c7d4
Compare
Member
Author
|
I added test samples to the test suite. |
illwieckz
force-pushed
the
illwieckz/normalize-jpg-sample
branch
2 times, most recently
from
August 5, 2026 03:02
9985489 to
0380e78
Compare
Open
illwieckz
force-pushed
the
illwieckz/normalize-jpg-sample
branch
4 times, most recently
from
August 7, 2026 02:00
2379243 to
4f450d2
Compare
illwieckz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept grayscale JPEGs with non-1x1 sampling factors (when loaded by
crn_jpgd.cpp)Some grayscale JPEG files contain non-1x1 sampling factors even though they only have a single luminance component. Treat these as grayscale JPEGs with 1x1 sampling instead of rejecting them.
This fixes loading and converting
flr_tmtl_bump.jpgfrom Xonotic.Fix #86:
flr_tmtl_bump.jpg#86