ci/test.lua: announce configured done_command before running tests - #5956
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
A bare positional argument is interpreted as the done_command, not a test filter, which is easy to misread when invoking the harness by hand (e.g. 'test plugins/foo' silently runs the entire suite). Print the configured done_command up front so a misparse is immediately visible instead of surfacing only after the full suite finishes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
done_commandbefore the test run startsdone_command, not a test filter — e.g.test plugins/buildingplansilently runs the entire suite withplugins/buildingplanqueued as the post-test command (which then errors as an unrecognized command at the end)Test plan
test -d <dir> -t <pattern> <positional>against a live fortress