sonarscanner-dotnet: apply sonar-exclusions and rename existing args to align defaults - #242
Open
aahmed-dfe wants to merge 3 commits into
Open
sonarscanner-dotnet: apply sonar-exclusions and rename existing args to align defaults#242aahmed-dfe wants to merge 3 commits into
aahmed-dfe wants to merge 3 commits into
Conversation
aahmed-dfe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
sonarscanner-dotnetalready exposes exclusion forcoverage, but it does not expose excluding files foranalysis. OnEducationProviderRegistrywe consume externalgovuk-frontendand other css bundles. These css bundles can have scan violations that we do not control as observed DFE-Digital/education-provider-registry-web#56 (comment).We may write custom quality-gate rules to tune these violations out, but exclusion of external assets should be possible.
Changes proposed in this pull request
This PR exposes the
sonarscan-exclusionsinput to the workflow, similar to coverage-exclusions.Guidance to review
Can be consumed from fork and applied.
Tested here DFE-Digital/education-provider-registry-web@b1a1f6f
Checklist
Devopslabel