Add very basic PhotoPipe selection (including z-band) - #281
Merged
Conversation
merge updates from develop to feature branch
…pplied there next)
- Mask gains kind 'not_equal_2bands' (keep object if value differs from sentinel in either band column), implemented in Mask.apply() on top of the shared apply_condition grammar - second column is explicit (col_name2 in config), not col_name+'2'; missing col_name2 fails fast - FITS-header descr now reconstructs the cut: '!=-99 in mag_z or mag_z2' - print_condition covers the new kind; Mask docstring documents it - config: typo + trailing-whitespace nits, explicit col_name2 - tests: OR semantics, fail-fast, descr Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0131j6RFmxW2va6XTTapBVqo
Pushed by the lint gate.
Contributor
|
🤖 autofix pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #187 (Jack Elvin-Poole's branch, carried over with his commits — I couldn't push to the fork). Closes #229.
On top of Jack's change (a
not_equal_2bandsmask kind: keep objects with a valid measurement in either z-band column, plus the_ppv1mask config):develop— theMaskclass moved tomasks.pyin the restructuring (Restructuring: top-level layout + workflow/papers/scratch division #197/refactor(src): dissolve basic.py, give every module an honest home #199), so the mask kind is now implemented inMask.apply()on top of the sharedapply_conditiongrammar (Consolidate masking #181)col_name2in the config) rather than hardcodedcol_name + "2"; missingcol_name2fails fast!=-99 in MAG_GAAP_0p7_z or MAG_GAAP_0p7_z2) instead of "special, not equal to OR mask"test_masks.pyMartin approved the original in #187; review comments there are all addressed here.
🤖 Generated with Claude Code
https://claude.ai/code/session_0131j6RFmxW2va6XTTapBVqo