Skip to content

fix(web): stop reconnecting after explicit disconnect - #433

Open
fallintoplace wants to merge 1 commit into
ClickHouse:mainfrom
fallintoplace:fix/websocket-explicit-disconnect
Open

fix(web): stop reconnecting after explicit disconnect#433
fallintoplace wants to merge 1 commit into
ClickHouse:mainfrom
fallintoplace:fix/websocket-explicit-disconnect

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What changed

disconnect() used to close the socket and then let its close handler schedule a reconnect.

  • stop reconnecting after an explicit disconnect
  • clear and reset a cancelled reconnect timer
  • ignore callbacks from sockets that are no longer active
  • allow a later explicit connect() to enable reconnects again

Tests

  • npm test
  • changed-file ESLint
  • npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant