fix(cli): omit unset ClickPipe create booleans - #754
Merged
sdairs merged 1 commit intoSep 7, 2026
Conversation
sdairs
force-pushed
the
stack/595-create-omission-cli
branch
from
September 5, 2026 14:20
23874bf to
4bc52e0
Compare
37 tasks
This was
linked to
issues
Sep 5, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickPipe creates previously replaced omitted booleans with
false. That made every non-Kafka create containing another settings flag serialize the rejected Kafka-onlykafka_read_committedkey, and it prevented minimal creates from omittingsource.validateSamplesas intended.The create builder now carries both optional booleans through unchanged: omitted values stay absent, while explicit
trueandfalseremain present. Real-binary request tests cover exact Kafka true/false payloads, minimal omission, andkafka_read_committedomission for object-storage, Kinesis, and Pub/Sub creates that contain other settings. The README documents both omission rules and the existing PostgreSQL/MySQL sample-validation no-op.Validation:
cargo fmt --allcargo clippy -p clickhousectl -- -D warningscargo check -p clickhousectl --no-default-featurescargo clippy -p clickhousectl --all-targets --no-default-features -- -D warningscargo test -q -p clickhousectl(1,727 passed, 0 failed, 2 ignored)cargo check --workspace --all-featuresCloses #595.