Skip to content

fix(cli): omit unset ClickPipe create booleans - #754

Merged
sdairs merged 1 commit into
stack/595-create-omission-apifrom
stack/595-create-omission-cli
Sep 7, 2026
Merged

fix(cli): omit unset ClickPipe create booleans#754
sdairs merged 1 commit into
stack/595-create-omission-apifrom
stack/595-create-omission-cli

Conversation

@sdairs

@sdairs sdairs commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

ClickPipe creates previously replaced omitted booleans with false. That made every non-Kafka create containing another settings flag serialize the rejected Kafka-only kafka_read_committed key, and it prevented minimal creates from omitting source.validateSamples as intended.

The create builder now carries both optional booleans through unchanged: omitted values stay absent, while explicit true and false remain present. Real-binary request tests cover exact Kafka true/false payloads, minimal omission, and kafka_read_committed omission for object-storage, Kinesis, and Pub/Sub creates that contain other settings. The README documents both omission rules and the existing PostgreSQL/MySQL sample-validation no-op.

Validation:

  • cargo fmt --all
  • cargo clippy -p clickhousectl -- -D warnings
  • cargo check -p clickhousectl --no-default-features
  • cargo clippy -p clickhousectl --all-targets --no-default-features -- -D warnings
  • cargo test -q -p clickhousectl (1,727 passed, 0 failed, 2 ignored)
  • cargo check --workspace --all-features

Closes #595.

@sdairs sdairs added this to the v0.5.0 milestone Sep 5, 2026

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs merged commit e4a5c8b into main Sep 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants