fix(api): preserve optional ClickPipe create fields - #753
Open
sdairs wants to merge 2 commits into
Open
Conversation
sdairs
had a problem deploying
to
cloud-integration
September 5, 2026 14:10 — with
GitHub Actions
Error
sdairs
temporarily deployed
to
cloud-integration
September 5, 2026 14:20 — with
GitHub Actions
Inactive
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickPipeSettings.kafka_read_committedandClickPipePostSource.validate_sampleswere modeled as required booleans, which forced callers to serializefalsewhen those source-conditional create fields were unset. On 2026-09-05, a live object-storage create that omittedsource.validateSamplessucceeded; the same request withsettings.kafka_read_committed:falsefailed withSetting 'kafka_read_committed' is only supported for Kafka ClickPipes, and omitting that setting succeeded.This changes both request fields to
Option<bool>with absent values omitted from JSON. ExplicitSome(false)remains serialized. Narrow analyzer exemptions document the observed control-plane behavior, and model tests cover omitted and explicit-false payloads. The CLI receives compile-onlySome(...)adaptations in this prerequisite commit, so its wire behavior remains unchanged until the follow-up CLI commit.Validation:
cargo fmt --allcargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warningscargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzerpython3 -m unittest discover -s scripts/tests -p 'test_*.py'(91 passed with commit signing disabled for the temporary-repository test)cargo check --workspace --all-featuresThe prerequisite also adapts three CLI unit assertions to the new types. Its no-default all-target Clippy, affected unit tests and full CLI test compilation pass before the behavior-changing follow-up.
Prerequisite for #595.