feat(cloud): expose complete ClickPipe updates - #752
Open
sdairs wants to merge 1 commit into
Open
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
cloud clickpipe update <service-id> <clickpipe-id> --config-file FILE|-for the complete current ClickPipe PATCH surface. Typed JSON input covers root fields and all seven supported source arms; omitted fields stay off the wire, explicit false/zero/empty values survive, and BigQuery is rejected because the API has no PATCH arm.Input is validated before network access, including unknown nested fields, catch-all enum values, required nested MySQL/MongoDB/Pub/Sub fields, Kafka credential unions and authentication correspondence, multiple source providers, and empty no-op bodies. Kafka IAM role and workload identity updates omit credentials, while CA-only and reverse-private-endpoint-only updates no longer require fabricated credential data. The command uses the existing typed API method through an organization-aware
CloudClientwrapper, is classified as a write for OAuth fail-fast behavior, and renders both JSON and human responses.Tests cover file/stdin parsing, minimal and maximal builders, exact real-binary PATCH bodies for Kafka, Kinesis, object storage, Pub/Sub, Postgres, MySQL, and MongoDB, root fields, IAM role/workload identity and CA-only Kafka shapes, omission/empty-value behavior, sparse responses, API failures, invalid input, and OAuth rejection.
Validation:
cargo fmt --all --checkcargo clippy -p clickhousectl -- -D warningscargo check -p clickhousectl --no-default-featurescargo clippy -p clickhousectl --all-targets --no-default-features -- -D warningscargo test -p clickhousectl— 1144 unit passed/1 ignored, 377 Cloud request-shape passed/1 ignored, and all local/telemetry binaries passedCloses #569