fix(api): preserve partial ClickPipe PATCH fields - #751
Open
sdairs wants to merge 1 commit into
Open
Conversation
sdairs
temporarily deployed
to
cloud-integration
September 5, 2026 14:06 — with
GitHub Actions
Inactive
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the ClickPipe PATCH request models so fields proven optional can be omitted instead of forcing callers to fabricate credentials, settings, arrays, or
validateSamples: false. Kafka credentials and reverse private endpoint IDs, Postgres credentials/settings/add/remove mappings, and sourcevalidateSamplesnow use omission-preservingOptionfields. Destinationcolumnsremains required because the live API rejects an included empty destination object.The narrow analyzer exemptions are grounded by a live object-storage PATCH on 2026-09-05 and the official Terraform provider's released Kafka update path and merged mappings-only fix (ClickHouse/terraform-provider-clickhouse#618). Model tests distinguish omission from explicit false and empty arrays, including Kafka CA-only changes and partial Postgres changes.
Validation:
cargo fmt --all --checkcargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warningscargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzerpython3 scripts/check-openapi-drift.py --dry-run— 0 actionable driftPrerequisite for #569.