Skip to content

fix(api): preserve partial ClickPipe PATCH fields - #751

Open
sdairs wants to merge 1 commit into
stack/747-cdc-live-fixturefrom
stack/569-patch-omission-api
Open

fix(api): preserve partial ClickPipe PATCH fields#751
sdairs wants to merge 1 commit into
stack/747-cdc-live-fixturefrom
stack/569-patch-omission-api

Conversation

@sdairs

@sdairs sdairs commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Corrects the ClickPipe PATCH request models so fields proven optional can be omitted instead of forcing callers to fabricate credentials, settings, arrays, or validateSamples: false. Kafka credentials and reverse private endpoint IDs, Postgres credentials/settings/add/remove mappings, and source validateSamples now use omission-preserving Option fields. Destination columns remains required because the live API rejects an included empty destination object.

The narrow analyzer exemptions are grounded by a live object-storage PATCH on 2026-09-05 and the official Terraform provider's released Kafka update path and merged mappings-only fix (ClickHouse/terraform-provider-clickhouse#618). Model tests distinguish omission from explicit false and empty arrays, including Kafka CA-only changes and partial Postgres changes.

Validation:

  • cargo fmt --all --check
  • cargo clippy -p clickhouse-cloud-api -p clickhouse-openapi-analyzer --all-targets -- -D warnings
  • cargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzer
  • python3 scripts/check-openapi-drift.py --dry-run — 0 actionable drift
  • Python script tests: 90 passed in the aggregate; the single sandbox-blocked temporary Git commit fixture passed on its exact unsandboxed rerun

Prerequisite for #569.

@sdairs sdairs added this to the v0.5.0 milestone Sep 5, 2026
@sdairs sdairs added the run-cloud-integration Run live Cloud integration tests for this PR head label Sep 5, 2026
@sdairs
sdairs temporarily deployed to cloud-integration September 5, 2026 14:06 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-cloud-integration Run live Cloud integration tests for this PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add clickpipe update for post-create source changes (Postgres/MySQL CDC settings, table mappings, connection)

1 participant