feat(cloud): manage organization custom roles - #744
Merged
Conversation
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organization role IDs were required by member, invitation, and API-key commands, but the CLI could neither discover nor manage those roles. This adds
cloud org role list|get|create|update|deleteover the five existing GA API methods.Create and update accept the complete typed role request as a JSON file or stdin, including actors, multiple policies, ALLOW/DENY, resources, permissions, grants, and roleV2 tags. Input rejects unknown fields at every nesting level and rejects unknown enum values before HTTP. Updates are partial: omitted fields stay unchanged, while supplied actor and policy arrays replace their complete lists. List/get support OAuth; writes fail fast unless API-key authentication is active. Human output preserves the system/custom distinction and tolerates sparse responses, while JSON output returns the typed API data.
The README now documents role discovery and a complete nested custom-role workflow, and member/invitation/key help points to
cloud org role listfor role IDs.Validation:
cargo fmt --allcargo clippy -p clickhousectl -- -D warningscargo check -p clickhousectl --no-default-featurescargo clippy -p clickhousectl --all-targets --no-default-features -- -D warningscargo test -p clickhousectlCloses #577.