fix(service): normalize IP removal warning matches - #738
Open
sdairs wants to merge 1 commit into
Open
Conversation
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloud service update --remove-ip-allowvalidated and normalizedSOURCE[=DESCRIPTION]values for the PATCH request, but warning detection compared the original CLI text with the current service sources. A described or padded removal therefore succeeded while incorrectly reporting that no entry was removed.Warning detection now consumes the already-validated request entries and compares their parsed
sourcefields. Descriptions and surrounding source whitespace no longer cause false warnings, invalid entries still fail before any API request, and unmatched removals continue to warn through the existing output channel.Tests cover described and padded IPv4/IPv6 matches, normalized unmatched warnings, the real CLI PATCH body and stderr behavior, and pre-network invalid-input rejection.
Validation: formatting, default clippy, no-default check and all-target clippy passed; five focused unit tests and both relevant real-binary mock tests passed.
References #589.
Follow-up correction for PR #721.