feat(clickpipes): expose source tuning options - #731
Open
sdairs wants to merge 1 commit into
Open
Conversation
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickPipe create commands could not send several source settings that the Cloud API supports. Kafka also dropped
exactlyOnce, had no inline Protobuf schema path for create or discovery, and could not build the Azure Event Hubs connection-string credential shape.This change exposes the missing controls:
--exactly-once; create and schema discovery accept a Protobuf schema file or stdin, base64-encode it, enforce the encoded 1 MiB API limit, and reject it outside Protobuf or alongside schema-registry flags.{ "connectionString": ... }credential object with PLAIN authentication.The request builders preserve omission for every optional setting, preserve explicit
false, enforce the API's integer minima before file or HTTP work, and validate Kafka/MySQL/MongoDB enum inputs against analyzer-checked APIVALUES. Kafka workload identity remains reserved for #690.Validation:
cargo fmt --all --checkcargo clippy -p clickhousectl -- -D warningscargo check -p clickhousectl --no-default-featurescargo clippy -p clickhousectl --all-targets --no-default-features -- -D warningscargo test -p clickhousectl --bin clickhousectl cloud::clickpipes::tests(139 passed)cargo test -p clickhousectl --test cli_request_shape_test issue_593(5 passed)cargo test -p clickhousectl(full suite passed; 2 explicitly ignored tests)Closes #593.