fix(audit): semantic bugs, null cards, OI labels, citation direction - #2033
Merged
Conversation
…on direction, bench 233 * fix(audit): answer leads semantics, freshness copy, null bench cards, OI label * fix(audit): stablecoin/bridge leads semantics, drop hardcoded refresh cadence on answers page * fix: perp-amm-volume-share duplicate bench number 043 -> 233 * fix(citation): direction-aware headlineSentence for lower-is-better metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes from audit review:
alternatives/[slug]: filter null perp bench cards (section hidden when no metrics measured)products/[slug]: remove hardcoded "refreshed every minute" from fallback descriptionanswers/[slug]: remove hardcoded ", refreshed every minute." footnoteperp-venue-external.ts: rename "Open Interest" → "OI (all markets)" in extraKpis to distinguish from benchmark KPI strip (resolves $9B vs $64B Hyperliquid OI confusion)citation.ts:headlineSentence()now uses "posts the lowest" for lower-is-better metrics instead of "leads" — affects /api/citable, /api/llm-context, MCP, JSON-LDbenchmarks/perp-amm-volume-share.yml: fix duplicate bench number 043 → 2337 answer YAMLs with inverted directional language for lower-is-better metrics: