fix: resolve Gemini history image references - #9874
Merged
Soulter merged 1 commit intoAug 31, 2026
Merged
Conversation
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Soulter
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini conversation history can contain image references accepted by AstrBot's shared media resolver, including local paths. The adapter's history converter still assumed every image was a base64 data URI, so a local history image raised before the provider request and triggered fallback.
Modifications / 改动点
Resolve Gemini history image references through the existing shared media resolver.
Make conversation preparation asynchronous and await it in both streaming and non-streaming request paths.
Add a regression test for a local WebP history image and update existing conversation tests for the async preparation path.
No new dependencies.
This is NOT a breaking change. / 这不是一个破坏性变更。
Verification steps / 验证步骤
Test results / 运行结果
Checklist / 检查清单
Summary by Sourcery
Fix Gemini history image handling so supported media references are resolved before provider requests.
Bug Fixes:
Enhancements:
Tests: