Skip to content

Docs: Updates minimum version of .NET required & updates Document.Save. - #253

Open
jamie-lemon wants to merge 1 commit into
mainfrom
docs-update
Open

Docs: Updates minimum version of .NET required & updates Document.Save.#253
jamie-lemon wants to merge 1 commit into
mainfrom
docs-update

Conversation

@jamie-lemon

Copy link
Copy Markdown
Contributor

No description provided.

@jamie-lemon

Copy link
Copy Markdown
Contributor Author

@MaksymTkachuk I'm just confirming the preserve_metadata param in PyMuPDF and will update this. note, our .NET source code snakes cases these params - not a big deal , but the docs were wrong. Also we have a parameter appearance - I don't know why? Must be old stuff .and we should remove it from the source code ... please review!

@MaksymTkachuk

MaksymTkachuk commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

I'm just confirming the preserve_metadata param in PyMuPDF and will update this. note, our .NET source code snakes cases these params - not a big deal , but the docs were wrong. Also we have a parameter appearance - I don't know why? Must be old stuff .and we should remove it from the source code ... please review!

@jamie-lemon
preserve_metadata in snake_case was my mistake.
For C# public APIs, parameters should use camelCase where possible, so I’ve updated them. I’ll upload the result soon.

Examples: preserve_metadata → preserveMetadata, owner_pw → ownerPW, user_pw → userPW, and the other snake_case Save parameters likewise.

On appearance parameter: it is present in PyMuPDF’s code, but not in the PyMuPDF docs. I think we should keep it, since it can still be passed through to the MuPDF engine.
I couldn't find an example of this parameter being used in PyMuPDF, but it is supported in MuPDF.

What do you think?

@jamie-lemon

Copy link
Copy Markdown
Contributor Author

@MaksymTkachuk
Yep - let's keep appearance in there then ( will try and find out what this parameter does too )
If you get the PR in to rename the parameters to camel case then I'll update the this PR again here when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants