feat: add git COMMIT_EDITMSG mode - #5
Merged
bajrangCoder merged 2 commits intoJul 10, 2026
Conversation
bajrangCoder
reviewed
Jul 8, 2026
|
|
||
| DiffZone { DiffBlock+ } | ||
|
|
||
| DiffBlock { DiffGitLine (DiffMetaLine | DiffContextLine)* } |
Member
There was a problem hiding this comment.
DiffBlock never references Hunk, so real patch lines parse as recovery errors. npm run generate reports DiffHunkHeader, DiffAddedLine, DiffRemovedLine, and Hunk as unused.
bajrangCoder
reviewed
Jul 8, 2026
| DiffContextLine, | ||
| } from "./parser.terms.js"; | ||
|
|
||
| const COMMIT_LINE_WARM_LENGTH = 30; |
Member
There was a problem hiding this comment.
Subject lines start getting MessageWarn after only 30 chars, and MessageWarn is styled as tags.invalid. That makes ordinary commit subjects like feat: add git COMMIT_EDITMSG mode partially invalid even though they are well below the common 50/72 guideline.
bajrangCoder
requested changes
Jul 8, 2026
bajrangCoder
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.