Skip to content

Update OAuth Authorization Code Flow documentation - #181

Merged
Heimmot24 merged 5 commits into
mainfrom
oauth-aanpassingen
Sep 10, 2026
Merged

Update OAuth Authorization Code Flow documentation#181
Heimmot24 merged 5 commits into
mainfrom
oauth-aanpassingen

Conversation

@Heimmot24

Copy link
Copy Markdown
Collaborator

Update OAuth Authorization Code Flow documentation to correct parameter order and add refresh token retrieval steps

…er order and add refresh token retrieval steps
Copilot AI lite review requested due to automatic review settings September 10, 2026 09:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The response fields list is currently malformed and documents an incorrect token_type value, which can mislead consumers.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

review nodig: ja
labels: 📚 leerzaam — deze PR is leerzaam omdat hij expliciet laat zien hoe je met een refresh token een nieuw access/refresh token ophaalt binnen de Authorization Code Flow met PKCE.

Deze PR actualiseert de documentatie voor de OAuth Authorization Code Flow (met PKCE) voor Profit door de parameterlijst/voorbeeld-URL te corrigeren en een expliciete refresh-token stap toe te voegen.

Changes:

  • Scope verwijderd uit de autorisatie-request parameters en het cURL URL-voorbeeld (NL/EN).
  • Stap toegevoegd voor het ophalen van een nieuw access token (en refresh token) via grant_type=refresh_token (NL/EN).
  • Stapnummering aangepast om de refresh-token stap op te nemen (NL/EN).
File summaries
File Description
markdownpages/profit/nl/authentication.md Past Authorization Code Flow-parameters en voegt refresh-token stap toe in NL-documentatie.
markdownpages/profit/en/authentication.md Past Authorization Code Flow-parameters en voegt refresh-token stap toe in EN-documentatie.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread markdownpages/profit/en/authentication.md
Comment thread markdownpages/profit/nl/authentication.md
Heimmot24 and others added 2 commits September 10, 2026 11:37
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Heimmot24
Heimmot24 merged commit e234dd9 into main Sep 10, 2026
8 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

De response-veldenlijst voor de authorization code flow heeft dubbele/misgenummerde output door een gecombineerde token_type/expires_in regel, wat in de gerenderde documentatie fout gaat.

Review details

Suppressed comments (2)

markdownpages/profit/nl/authentication.md:170

  • 🟠 medium: Deze lijst met response-velden combineert token_type en expires_in in één item via een <br>, terwijl expires_in ook nog als apart item eronder staat. Dit geeft dubbele/misgenummerde output in de gerenderde documentatie; maak er twee aparte lijstitems van.
    3.	token_type: Bearer

markdownpages/profit/en/authentication.md:171

  • 🟠 medium: This response-fields list item combines token_type and expires_in using a <br>, while expires_in is also listed again on the next line. This produces duplicated/misnumbered output in rendered docs; keep token_type and expires_in as separate list items.
    3. token_type: Bearer
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@Heimmot24
Heimmot24 deleted the oauth-aanpassingen branch September 10, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants