Skip to content

Commit 4a008bd

Browse files
committed
Address Petr's review
1 parent cc11131 commit 4a008bd

5 files changed

Lines changed: 6 additions & 11 deletions

File tree

Modules/_testlimitedcapi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "pyconfig.h" // Py_GIL_DISABLED
99

1010
#ifdef Py_GIL_DISABLED
11-
// FIXME: use the Py_TARGET_ABI3T
11+
// Cannot test the limited C API
1212
#else
1313
// Use the oldest limited C API version
1414
# define Py_LIMITED_API 0x03020000

Modules/_testlimitedcapi/heaptype_relative.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "pyconfig.h" // Py_GIL_DISABLED
22
#ifdef Py_GIL_DISABLED
3-
// FIXME: use the Py_TARGET_ABI3T
3+
// Cannot test the limited C API
44
#else
55
// Need limited C API version 3.15 for _DuringGC functions
66
# define Py_LIMITED_API 0x030f0000

Modules/_testlimitedcapi/parts.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Use the limited C API
1010
#ifdef Py_GIL_DISABLED
11-
// FIXME: use the Py_TARGET_ABI3T
11+
// Cannot test the limited C API
1212
#elif !defined(Py_LIMITED_API)
1313
// Need limited C API version 3.5 for PyModule_AddFunctions()
1414
# define Py_LIMITED_API 0x03050000

Modules/_testlimitedcapi/slots.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
1-
#include "pyconfig.h" // Py_GIL_DISABLED
2-
#ifdef Py_GIL_DISABLED
3-
# define Py_TARGET_ABI3T 0x030f0000
4-
#else
5-
// Need limited C API version 3.15 for PyType_FromSlots()
6-
# define Py_LIMITED_API 0x030f0000
7-
#endif
1+
// Need limited C API version 3.15 for PyType_FromSlots()
2+
#define Py_LIMITED_API 0x030f0000
83

94
#include "parts.h"
105

Modules/_testlimitedcapi/vectorcall_limited.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
#include "pyconfig.h" // Py_GIL_DISABLED
44
#ifdef Py_GIL_DISABLED
5-
// FIXME: use the Py_TARGET_ABI3T
5+
// Cannot test the limited C API
66
#else
77
// Need limited C API version 3.12 for PyObject_Vectorcall()
88
# define Py_LIMITED_API 0x030c0000

0 commit comments

Comments
 (0)