Hello there 馃憢馃徎,
Actually, the comparison between the user having commited and gitlab users is done this way:
if user['name'] == commit['author_name']:
which I find too strict.
Sadly, Gitlag does not include the username in the commits API. That would have been the best way to go.
However, I think that a comparison ignoring accents and case could really improve the matching. Chances that two commiters with the names Bob example and Bob Example are two different people are IMHO very slim.
If the Gitlab user is set to Bob Ex盲mple, no commits would match.
What do you think?
I can open a PR to improve this.
Hello there 馃憢馃徎,
Actually, the comparison between the user having commited and gitlab users is done this way:
which I find too strict.
Sadly, Gitlag does not include the username in the commits API. That would have been the best way to go.
However, I think that a comparison ignoring accents and case could really improve the matching. Chances that two commiters with the names
Bob exampleandBob Exampleare two different people are IMHO very slim.If the Gitlab user is set to
Bob Ex盲mple, no commits would match.What do you think?
I can open a PR to improve this.